[kudu-CR] rpc: Add min / max negotiation threads

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change.

Change subject: rpc: Add min / max negotiation threads
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4574/1/src/kudu/rpc/messenger.h
File src/kudu/rpc/messenger.h:

PS1, Line 87: int
> Semantically, is it possible to get negative number here (e.g., like for un
typically we try to use signed ints and assertions for "it shouldn't be negative" rather than uints, since uints have the surprising behavior of wrapping to super-large positive numbers when you least expect it.

https://google.github.io/styleguide/cppguide.html#Integer_Types


-- 
To view, visit http://gerrit.cloudera.org:8080/4574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife98b39d5f3a340702151ab27dc8026c8bac12ac
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes