You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/06/04 05:23:10 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4269: Add
interface and implementations for the new segment assignment
codecov-io edited a comment on issue #4269: Add interface and implementations for the new segment assignment
URL: https://github.com/apache/incubator-pinot/pull/4269#issuecomment-497900364
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=h1) Report
> Merging [#4269](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/ccab9a1986bbd86a44933df18bcd8dc824bd4964?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `80.84%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4269 +/- ##
============================================
+ Coverage 67.21% 67.36% +0.15%
Complexity 20 20
============================================
Files 1039 1046 +7
Lines 51535 51832 +297
Branches 7228 7275 +47
============================================
+ Hits 34638 34916 +278
+ Misses 14534 14528 -6
- Partials 2363 2388 +25
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...helix/core/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ller/helix/core/assignment/InstancePartitions.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zLmphdmE=) | `44.82% <44.82%> (ø)` | `0 <0> (?)` | |
| [...ment/segment/SegmentAssignmentStrategyFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5RmFjdG9yeS5qYXZh) | `80% <80%> (ø)` | `0 <0> (?)` | |
| [...main/java/org/apache/pinot/common/utils/Pairs.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvUGFpcnMuamF2YQ==) | `82.89% <84.61%> (+4.51%)` | `0 <0> (ø)` | :arrow_down: |
| [...ent/segment/RealtimeSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZVNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `88.88% <88.88%> (ø)` | `0 <0> (?)` | |
| [...ore/assignment/segment/SegmentAssignmentUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFV0aWxzLmphdmE=) | `92.85% <92.85%> (ø)` | `0 <0> (?)` | |
| [...t/segment/BalanceNumSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9CYWxhbmNlTnVtU2VnbWVudEFzc2lnbm1lbnRTdHJhdGVneS5qYXZh) | `93.02% <93.02%> (ø)` | `0 <0> (?)` | |
| [...segment/ReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZXBsaWNhR3JvdXBTZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `93.27% <93.27%> (ø)` | `0 <0> (?)` | |
| [...core/operator/dociditerators/AndDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9BbmREb2NJZEl0ZXJhdG9yLmphdmE=) | `51.72% <0%> (-31.04%)` | `0% <0%> (ø)` | |
| [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvTWluTWF4UmFuZ2VQYWlyLmphdmE=) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=footer). Last update [ccab9a1...a088a2b](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org