You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ba...@apache.org on 2009/09/15 07:56:05 UTC
svn commit: r815077 -
/commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java
Author: bayard
Date: Tue Sep 15 05:56:05 2009
New Revision: 815077
URL: http://svn.apache.org/viewvc?rev=815077&view=rev
Log:
Merging from -r468106:814127 of collections_jdk5_branch - namely where this code was generified; mostly in r738956.
Also see the following revisions:
------------------------------------------------------------------------
r740150 | mbenson | 2009-02-02 15:24:00 -0800 (Mon, 02 Feb 2009) | 1 line
make all [collections] maps implement IterableMap
------------------------------------------------------------------------
Modified:
commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java
Modified: commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java?rev=815077&r1=815076&r2=815077&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java (original)
+++ commons/proper/collections/trunk/src/java/org/apache/commons/collections/map/FixedSizeMap.java Tue Sep 15 05:56:05 2009
@@ -21,11 +21,11 @@
import java.io.ObjectOutputStream;
import java.io.Serializable;
import java.util.Collection;
-import java.util.Iterator;
import java.util.Map;
import java.util.Set;
import org.apache.commons.collections.BoundedMap;
+import org.apache.commons.collections.IterableMap;
import org.apache.commons.collections.collection.UnmodifiableCollection;
import org.apache.commons.collections.set.UnmodifiableSet;
@@ -56,9 +56,9 @@
* @author Stephen Colebourne
* @author Paul Jack
*/
-public class FixedSizeMap
- extends AbstractMapDecorator
- implements Map, BoundedMap, Serializable {
+public class FixedSizeMap<K, V>
+ extends AbstractMapDecorator<K, V>
+ implements Map<K, V>, BoundedMap<K, V>, Serializable {
/** Serialization version */
private static final long serialVersionUID = 7450927208116179316L;
@@ -69,8 +69,8 @@
* @param map the map to decorate, must not be null
* @throws IllegalArgumentException if map is null
*/
- public static Map decorate(Map map) {
- return new FixedSizeMap(map);
+ public static <K, V> IterableMap<K, V> decorate(Map<K, V> map) {
+ return new FixedSizeMap<K, V>(map);
}
//-----------------------------------------------------------------------
@@ -80,7 +80,7 @@
* @param map the map to decorate, must not be null
* @throws IllegalArgumentException if map is null
*/
- protected FixedSizeMap(Map map) {
+ protected FixedSizeMap(Map<K, V> map) {
super(map);
}
@@ -105,22 +105,23 @@
* @throws ClassNotFoundException
* @since Commons Collections 3.1
*/
+ @SuppressWarnings("unchecked")
private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
in.defaultReadObject();
map = (Map) in.readObject();
}
//-----------------------------------------------------------------------
- public Object put(Object key, Object value) {
+ public V put(K key, V value) {
if (map.containsKey(key) == false) {
throw new IllegalArgumentException("Cannot put new key/value pair - Map is fixed size");
}
return map.put(key, value);
}
- public void putAll(Map mapToCopy) {
- for (Iterator it = mapToCopy.keySet().iterator(); it.hasNext(); ) {
- if (mapToCopy.containsKey(it.next()) == false) {
+ public void putAll(Map<? extends K, ? extends V> mapToCopy) {
+ for (K key : mapToCopy.keySet()) {
+ if (!containsKey(key)) {
throw new IllegalArgumentException("Cannot put new key/value pair - Map is fixed size");
}
}
@@ -131,23 +132,23 @@
throw new UnsupportedOperationException("Map is fixed size");
}
- public Object remove(Object key) {
+ public V remove(Object key) {
throw new UnsupportedOperationException("Map is fixed size");
}
- public Set entrySet() {
- Set set = map.entrySet();
+ public Set<Map.Entry<K, V>> entrySet() {
+ Set<Map.Entry<K, V>> set = map.entrySet();
// unmodifiable set will still allow modification via Map.Entry objects
return UnmodifiableSet.decorate(set);
}
- public Set keySet() {
- Set set = map.keySet();
+ public Set<K> keySet() {
+ Set<K> set = map.keySet();
return UnmodifiableSet.decorate(set);
}
- public Collection values() {
- Collection coll = map.values();
+ public Collection<V> values() {
+ Collection<V> coll = map.values();
return UnmodifiableCollection.decorate(coll);
}
@@ -158,5 +159,5 @@
public int maxSize() {
return size();
}
-
+
}