You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/09/28 02:32:06 UTC
Review Request 14382: Made Promise have a virtual destructor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14382/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/future.hpp daf4b92ce4086e8bd2b96c53d8f9baf70755bbde
Diff: https://reviews.apache.org/r/14382/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 14382: Made Promise have a virtual destructor.
Posted by Ben Mahler <be...@gmail.com>.
> On Sept. 28, 2013, 12:32 a.m., Ben Mahler wrote:
> > Ship It!
I've committed this for you as discussed, can you mark as submitted?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14382/#review26458
-----------------------------------------------------------
On Sept. 28, 2013, 12:32 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14382/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2013, 12:32 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp daf4b92ce4086e8bd2b96c53d8f9baf70755bbde
>
> Diff: https://reviews.apache.org/r/14382/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 14382: Made Promise have a virtual destructor.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14382/#review26458
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 28, 2013, 12:32 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14382/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2013, 12:32 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp daf4b92ce4086e8bd2b96c53d8f9baf70755bbde
>
> Diff: https://reviews.apache.org/r/14382/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>