[jira] [Commented] (HBASE-20546) Improve perf of RegionLocationFinder.mapHostNameToServerName

["Thiruvel Thirumoolan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505127#comment-16505127 ] 

Thiruvel Thirumoolan commented on HBASE-20546:
----------------------------------------------

I can move this map to ServerManager, so its always updated. Would that be ok?

Since its called from picker, its significant. It came up when I profiled balancer on our cluster setup.

> Improve perf of RegionLocationFinder.mapHostNameToServerName
> ------------------------------------------------------------
>
>                 Key: HBASE-20546
>                 URL: https://issues.apache.org/jira/browse/HBASE-20546
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.4.4, 2.0.0
>            Reporter: Thiruvel Thirumoolan
>            Assignee: Thiruvel Thirumoolan
>            Priority: Major
>             Fix For: 1.5.0, 2.0.1, 1.4.6
>
>         Attachments: HBASE-20546.branch-1.4.001.patch
>
>
> RegionLocationFinder.getTopBlockLocations() is called multiple times during balancer. While profiling on a large table balance, mapHostNameToServerName() seem to take a lot of time. One of the maps is repeatedly created for each iteration, while we can just initialize it once.
> Goes into both branch-1 and branch-2, although patches differ slightly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)