You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2026/09/08 06:34:54 UTC
Re: [PR] Perf: Take the comparison-free fast path in the grouped first/last accumulator when input is pre-ordered [datafusion]
codecov-commenter commented on PR #25050:
URL: https://github.com/apache/datafusion/pull/25050#issuecomment-5580411396
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/25050?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.91925%` with `55 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 81.72%. Comparing base ([`8a92281`](https://app.codecov.io/gh/apache/datafusion/commit/8a9228164fddeaa03c9ee510b641990e403f2eb5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b0d120b`](https://app.codecov.io/gh/apache/datafusion/commit/b0d120bedd6441f3d86ce82d942ae43b55e50bc0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/25050?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [datafusion/functions-aggregate/src/first\_last.rs](https://app.codecov.io/gh/apache/datafusion/pull/25050?src=pr&el=tree&filepath=datafusion%2Ffunctions-aggregate%2Fsrc%2Ffirst_last.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9mdW5jdGlvbnMtYWdncmVnYXRlL3NyYy9maXJzdF9sYXN0LnJz) | 82.91% | [1 Missing and 54 partials :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/25050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #25050 +/- ##
========================================
Coverage 81.72% 81.72%
========================================
Files 1127 1127
Lines 416519 416839 +320
Branches 416519 416839 +320
========================================
+ Hits 340401 340665 +264
Misses 56115 56115
- Partials 20003 20059 +56
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/25050?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org