You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2014/09/06 02:31:29 UTC
[jira] [Commented] (LUCENE-5820) SuggestStopFilter should have a
factory
[ https://issues.apache.org/jira/browse/LUCENE-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123887#comment-14123887 ]
Steve Rowe commented on LUCENE-5820:
------------------------------------
Varun, your patch looks good.
A few things that should be changed:
* Add license text to {{org.apache.lucene.search.suggest.analyzing.SuggestStopFilterFactory}}
* Remove version handling ({{luceneMatchVersion}}) from the factory ctor and the test class (this is the only version of the filter, no need for version-specific behavior).
* Remove unused imports - I noticed some in the test class.
> SuggestStopFilter should have a factory
> ---------------------------------------
>
> Key: LUCENE-5820
> URL: https://issues.apache.org/jira/browse/LUCENE-5820
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Varun Thacker
> Assignee: Steve Rowe
> Priority: Minor
> Attachments: LUCENE-5820.patch, LUCENE-5820.patch, LUCENE-5820.patch
>
>
> While trying to use the new Suggester in Solr I realized that SuggestStopFilter did not have a factory. We should add one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org