[GitHub] [incubator-superset] craig-rueda commented on pull request #11499: feat(SIP-39): Async query support for charts

[GitBox <gi...@apache.org>]

craig-rueda commented on pull request #11499:
URL: https://github.com/apache/incubator-superset/pull/11499#issuecomment-742735411


   Overall, looks good! One thing I noticed was a bit of hand-rolling around JWT handling. I suggest leaning on `flask-jwt-extended` for this, along with the ability for other teams to customize their "jwt manager" as to adhere to their internal use cases (flask-jwt-extended allows for customization of all things JWT related via a set of config options). I can see wanting to keep this functionality separate from other global JWT handling. At the very least, it would be great to make the security-related functionality pluggable so that it can be easily overridden and extended


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org