You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/24 07:50:50 UTC
[GitHub] [yunikorn-k8shim] 0yukali0 commented on a diff in pull request #486: [YUNIKORN-1423] Update README.md in placement examples that how to update configuration
0yukali0 commented on code in PR #486:
URL: https://github.com/apache/yunikorn-k8shim/pull/486#discussion_r1031150153
##########
deployments/examples/placements/README.md:
##########
@@ -20,13 +20,22 @@
App placements rules in Yunikorn contains `Provided Rule`, `User Name Rule`, `Fixed Rule`, `Tag Rule`.
Every placement example includes a example yaml file and a config yaml file.
The sleep pod is described in the example file and the partition is provided in the config yaml file.
-Before deploying the pods, the configuration field in yunikorn-release/helm/yunikorn/value.yaml should be replaced by the configuration field in the config.yaml.
* [Provided Rule](./provided)
* [User Name Rule](./username)
* [Fixed Rule](./fixed)
* [Tag Rule](./tag)
+## How to adopt the queues in `config.yaml`
+Before deploying the pods, threre are some modifications required in [release/value.yaml](yunikorn-release/helm/yunikorn/value.yaml).
+1. Replace the configuration field by the configuration in the `config.yaml`.
+2. Add `queue.yaml: ""` in `yunikornDefaults` field.
+```
+yunikornDefaults: {
+ queue.yaml: ""
Review Comment:
I trace the code in the https://github.com/apache/yunikorn-release/blob/master/helm-charts/yunikorn/templates/yunikorn-defaults.yaml#L60-L68。
It seems to get the key but it will not get the value.
So I use empty string here.
Is there a suggested value of the queues.yaml?
##########
deployments/examples/placements/README.md:
##########
@@ -20,13 +20,22 @@
App placements rules in Yunikorn contains `Provided Rule`, `User Name Rule`, `Fixed Rule`, `Tag Rule`.
Every placement example includes a example yaml file and a config yaml file.
The sleep pod is described in the example file and the partition is provided in the config yaml file.
-Before deploying the pods, the configuration field in yunikorn-release/helm/yunikorn/value.yaml should be replaced by the configuration field in the config.yaml.
* [Provided Rule](./provided)
* [User Name Rule](./username)
* [Fixed Rule](./fixed)
* [Tag Rule](./tag)
+## How to adopt the queues in `config.yaml`
+Before deploying the pods, threre are some modifications required in [release/value.yaml](yunikorn-release/helm/yunikorn/value.yaml).
+1. Replace the configuration field by the configuration in the `config.yaml`.
+2. Add `queue.yaml: ""` in `yunikornDefaults` field.
+```
+yunikornDefaults: {
+ queue.yaml: ""
Review Comment:
I traced the code in the https://github.com/apache/yunikorn-release/blob/master/helm-charts/yunikorn/templates/yunikorn-defaults.yaml#L60-L68。
It seems to get the key but it will not get the value.
So I use empty string here.
Is there a suggested value of the queues.yaml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org