You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Sai Krishna Kishore Beathanabhotla <be...@gmail.com> on 2015/11/09 11:03:15 UTC
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 10:03 a.m.)
Review request for MetaModel.
Repository: metamodel
Description
-------
Added validation to check for invalid characters and sheetname length for excel
Diffs
-----
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
Diff: https://reviews.apache.org/r/40074/diff/
Testing
-------
1) Added test cases for the same.
2) Verified with name greater than 31 characters.
3) Verified name with invalid characters like [ ] : \ / ? *
Thanks,
Sai Krishna Kishore Beathanabhotla
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105708
-----------------------------------------------------------
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java (line 48)
<https://reviews.apache.org/r/40074/#comment164320>
I notice here that the indentation is tab-based whereas the rest is using spaces.
- Kasper Sørensen
On nov. 9, 2015, 10:03 a.m., Sai Krishna Kishore Beathanabhotla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
>
> (Updated nov. 9, 2015, 10:03 a.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added validation to check for invalid characters and sheetname length for excel
>
>
> Diffs
> -----
>
> excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
> excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
>
> Diff: https://reviews.apache.org/r/40074/diff/
>
>
> Testing
> -------
>
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
>
>
> Thanks,
>
> Sai Krishna Kishore Beathanabhotla
>
>
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Sai Krishna Kishore Beathanabhotla <be...@gmail.com>.
> On Nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote:
> > Looks good to me!
Hi Kasper,
I am unable to commit as I don't have privilages to commit to metamodel project for my username, could you please help me resolve the issue.
- Sai Krishna Kishore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105809
-----------------------------------------------------------
On Nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beathanabhotla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 11:15 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added validation to check for invalid characters and sheetname length for excel
>
>
> Diffs
> -----
>
> excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
> excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
>
> Diff: https://reviews.apache.org/r/40074/diff/
>
>
> Testing
> -------
>
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
>
>
> Thanks,
>
> Sai Krishna Kishore Beathanabhotla
>
>
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Kasper Sørensen <i....@gmail.com>.
> On nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote:
> > Looks good to me!
>
> Sai Krishna Kishore Beathanabhotla wrote:
> Hi Kasper,
> I am unable to commit as I don't have privilages to commit to metamodel project for my username, could you please help me resolve the issue.
Hi Sai,
I've already committed and pushed to master ;-)
Could you close this review request - somehow I cannot do that, I guess it has to be the author who does that.
- Kasper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105809
-----------------------------------------------------------
On nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beathanabhotla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
>
> (Updated nov. 9, 2015, 11:15 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added validation to check for invalid characters and sheetname length for excel
>
>
> Diffs
> -----
>
> excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
> excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
>
> Diff: https://reviews.apache.org/r/40074/diff/
>
>
> Testing
> -------
>
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
>
>
> Thanks,
>
> Sai Krishna Kishore Beathanabhotla
>
>
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Kasper Sørensen <i....@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105809
-----------------------------------------------------------
Ship it!
Looks good to me!
- Kasper Sørensen
On nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beathanabhotla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
>
> (Updated nov. 9, 2015, 11:15 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added validation to check for invalid characters and sheetname length for excel
>
>
> Diffs
> -----
>
> excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
> excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
>
> Diff: https://reviews.apache.org/r/40074/diff/
>
>
> Testing
> -------
>
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
>
>
> Thanks,
>
> Sai Krishna Kishore Beathanabhotla
>
>
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Sai Krishna Kishore Beathanabhotla <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/#review105825
-----------------------------------------------------------
Ship it!
Ship It!
- Sai Krishna Kishore Beathanabhotla
On Nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beathanabhotla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40074/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 11:15 p.m.)
>
>
> Review request for MetaModel.
>
>
> Repository: metamodel
>
>
> Description
> -------
>
> Added validation to check for invalid characters and sheetname length for excel
>
>
> Diffs
> -----
>
> excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
> excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
>
> Diff: https://reviews.apache.org/r/40074/diff/
>
>
> Testing
> -------
>
> 1) Added test cases for the same.
> 2) Verified with name greater than 31 characters.
> 3) Verified name with invalid characters like [ ] : \ / ? *
>
>
> Thanks,
>
> Sai Krishna Kishore Beathanabhotla
>
>
Re: Review Request 40074: Added validation to check for invalid
characters and sheetname length for excel
Posted by Sai Krishna Kishore Beathanabhotla <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40074/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 11:15 p.m.)
Review request for MetaModel.
Repository: metamodel
Description
-------
Added validation to check for invalid characters and sheetname length for excel
Diffs (updated)
-----
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java f99ec89
excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java 97101bd
Diff: https://reviews.apache.org/r/40074/diff/
Testing
-------
1) Added test cases for the same.
2) Verified with name greater than 31 characters.
3) Verified name with invalid characters like [ ] : \ / ? *
Thanks,
Sai Krishna Kishore Beathanabhotla