You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/08 18:39:54 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request, #496: Upgrade Ginkgo and EnvTest
HoustonPutman opened a new pull request, #496:
URL: https://github.com/apache/solr-operator/pull/496
With upgrading EnvTest, we have a much easier setup for tests!
Ginkgo we are upgrading to v2, which has small back-incompatabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #496: Upgrade Ginkgo and EnvTest
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #496:
URL: https://github.com/apache/solr-operator/pull/496#issuecomment-1308998463
@janhoy and @gerlowskija I know y'all have both had issues with your M1 macbooks and the build system before. So I definitely want to have y'all successfully do a run through before merging this 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #496: Upgrade Ginkgo and EnvTest
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #496:
URL: https://github.com/apache/solr-operator/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #496: Upgrade Ginkgo and EnvTest
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #496:
URL: https://github.com/apache/solr-operator/pull/496#issuecomment-1309000136
Note, when you upgrade your golang version (1.19 is now required) I highly suggest running `make clean mod-tidy` to clear all of your cached dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on pull request #496: Upgrade Ginkgo and EnvTest
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on PR #496:
URL: https://github.com/apache/solr-operator/pull/496#issuecomment-1315495102
This works for me! I had a small issue with bad syntax on a `chmod` command used by `make clean`. (I've pushed that fix up to this PR after a short conversation offline with Houston)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org