You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by Daniel Kuppitz <me...@gremlin.guru> on 2018/03/07 16:24:04 UTC
Merge of TINKERPOP-1777
Hi everyone,
this morning I accidentally merged TINKERPOP-1777
<https://github.com/apache/tinkerpop/pull/805> into master/. For some
reason, I was pretty sure that I got enough VOTEs, but in fact, it was only
me who really voted. I guess I mixed up some notification emails and merged
it a bit too quickly.
Please let me know if you have any complaints, I think I can roll it back,
but personally, I don't think that this merge was too bad.
Cheers,
Daniel
Re: Merge of TINKERPOP-1777
Posted by Jorge Bay Gondra <jo...@gmail.com>.
Looks good to me, so you have my vote :)
No need to rollback IMO.
On Wed, Mar 7, 2018 at 6:05 PM, Stephen Mallette <sp...@gmail.com>
wrote:
> I expected to do a +1 today - personally, i don't think you need go through
> the hassle of rollback for an official vote.
>
> On Wed, Mar 7, 2018 at 11:24 AM, Daniel Kuppitz <me...@gremlin.guru> wrote:
>
> > Hi everyone,
> >
> > this morning I accidentally merged TINKERPOP-1777
> > <https://github.com/apache/tinkerpop/pull/805> into master/. For some
> > reason, I was pretty sure that I got enough VOTEs, but in fact, it was
> only
> > me who really voted. I guess I mixed up some notification emails and
> merged
> > it a bit too quickly.
> >
> > Please let me know if you have any complaints, I think I can roll it
> back,
> > but personally, I don't think that this merge was too bad.
> >
> > Cheers,
> > Daniel
> >
>
Re: Merge of TINKERPOP-1777
Posted by Stephen Mallette <sp...@gmail.com>.
I expected to do a +1 today - personally, i don't think you need go through
the hassle of rollback for an official vote.
On Wed, Mar 7, 2018 at 11:24 AM, Daniel Kuppitz <me...@gremlin.guru> wrote:
> Hi everyone,
>
> this morning I accidentally merged TINKERPOP-1777
> <https://github.com/apache/tinkerpop/pull/805> into master/. For some
> reason, I was pretty sure that I got enough VOTEs, but in fact, it was only
> me who really voted. I guess I mixed up some notification emails and merged
> it a bit too quickly.
>
> Please let me know if you have any complaints, I think I can roll it back,
> but personally, I don't think that this merge was too bad.
>
> Cheers,
> Daniel
>