[GitHub] [geode] PurelyApplied opened pull request #2474: GEODE-5600: Unify SCM property caching.

["PurelyApplied (GitHub)" <gi...@apache.org>]

* Refactor gradle tasks generating .buildinfo
and GemFireVerion.properties files
* Treat .buildinfo as the source of truth for
those properties shared in GemFireVersion.properties

Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2474: GEODE-5600: Unify SCM property caching.

["metatype (GitHub)" <gi...@apache.org>]

IMO it's better to keep the root build script as clean and simple as possible.  But I don't have any objections as long it works :-)

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on issue #2474: GEODE-5600: Unify SCM property caching.

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

I'd really prefer to not use `rootProject` in the root-project gradle file. 

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2474: GEODE-5600: Unify SCM property caching.

["PurelyApplied (GitHub)" <gi...@apache.org>]

@rhoughton-pivot @dickcav @smgoller to review?

Side note: I still don't understand why I can't tag some of you in the Review Requested section.

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #2474: GEODE-5600: Unify SCM property caching.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Since it is only used in one place it didn’t make sense to me to have it located elsewhere.

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2474: GEODE-5600: Unify SCM property caching.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

@metatype ping!

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett closed pull request #2474: GEODE-5600: Unify SCM property caching.

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on pull request #2474: GEODE-5600: Unify SCM property caching.

["metatype (GitHub)" <gi...@apache.org>]

Would it make sense to keep this in the utilities build script?

[ Full content available at: https://github.com/apache/geode/pull/2474 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org