[GitHub] [trafficserver] bneradt commented on a change in pull request #7762: Add traffic_server command line option for debugging in Au test.

[GitBox <gi...@apache.org>]

bneradt commented on a change in pull request #7762:
URL: https://github.com/apache/trafficserver/pull/7762#discussion_r625376267



##########
File path: src/traffic_server/traffic_server.cc
##########
@@ -217,6 +235,7 @@ static ArgumentDescription argument_descriptions[] = {
   {"bind_stderr", '-', "Regular file to bind stderr to", "S512", &bind_stderr, "PROXY_BIND_STDERR", nullptr},
   {"accept_mss", '-', "MSS for client connections", "I", &accept_mss, nullptr, nullptr},
   {"poll_timeout", 't', "poll timeout in milliseconds", "I", &poll_timeout, nullptr, nullptr},
+  {"block", '-', "block for debug attach", "T", &cmd_block, nullptr, nullptr},

Review comment:
       This looks promising.
   
   I suggest we update the MakeATSProcess trafficserver extension in autest-site to take a flag that configures this for the user. Maybe `block_for_detach=False` and someone wanting to use this can pass `block_for_detatch=True` and this will set things up for that, doing the necessary to make things work for cmd being traffic_server or traffic_manager.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org