You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "robin977 (via GitHub)" <gi...@apache.org> on 2023/11/23 11:55:15 UTC
[PR] configcenter etcd support dubbo3.2 [dubbo-spi-extensions]
robin977 opened a new pull request, #243:
URL: https://github.com/apache/dubbo-spi-extensions/pull/243
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ ] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] configcenter etcd support dubbo3.2 [dubbo-spi-extensions]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #243:
URL: https://github.com/apache/dubbo-spi-extensions/pull/243#issuecomment-1833092174
## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`bf5e7b5`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/bf5e7b5e631c301ba21a24e445d00ddbd76c6e56?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 33.26% compared to head [(`f27be37`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/243?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 33.74%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.2.0 #243 +/- ##
============================================
+ Coverage 33.26% 33.74% +0.47%
- Complexity 511 517 +6
============================================
Files 161 161
Lines 5483 5477 -6
Branches 667 666 -1
============================================
+ Hits 1824 1848 +24
+ Misses 3451 3421 -30
Partials 208 208
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/243?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] configcenter etcd support dubbo3.2 [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng merged PR #243:
URL: https://github.com/apache/dubbo-spi-extensions/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] configcenter etcd support dubbo3.2 [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on code in PR #243:
URL: https://github.com/apache/dubbo-spi-extensions/pull/243#discussion_r1407852379
##########
dubbo-remoting-extensions/dubbo-remoting-etcd3/src/test/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientTest.java:
##########
@@ -67,7 +66,7 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.dubbo.remoting.etcd.Constants.SESSION_TIMEOUT_KEY;
-@Disabled
+//@Disabled
Review Comment:
please don't remove annotation Disabled
##########
dubbo-remoting-extensions/dubbo-remoting-etcd3/src/test/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientWrapperTest.java:
##########
@@ -54,7 +54,7 @@
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.spy;
-@Disabled
+//@Disabled
Review Comment:
please don't remove annotation Disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] configcenter etcd support dubbo3.2 [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on code in PR #243:
URL: https://github.com/apache/dubbo-spi-extensions/pull/243#discussion_r1407852379
##########
dubbo-remoting-extensions/dubbo-remoting-etcd3/src/test/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientTest.java:
##########
@@ -67,7 +66,7 @@
import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.dubbo.remoting.etcd.Constants.SESSION_TIMEOUT_KEY;
-@Disabled
+//@Disabled
Review Comment:
please don't remove @Disabled
##########
dubbo-remoting-extensions/dubbo-remoting-etcd3/src/test/java/org/apache/dubbo/remoting/etcd/jetcd/JEtcdClientWrapperTest.java:
##########
@@ -54,7 +54,7 @@
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.spy;
-@Disabled
+//@Disabled
Review Comment:
please don't remove @Disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org