You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "aiceflower (via GitHub)" <gi...@apache.org> on 2023/07/25 12:29:19 UTC

[GitHub] [linkis] aiceflower opened a new pull request, #4820: issue-4819: fix illegal ec status and print error log

aiceflower opened a new pull request, #4820:
URL: https://github.com/apache/linkis/pull/4820

   ### What is the purpose of the change
   
   1. fix illegal ec status 
   2. fix print error log issue
   ### Related issues/PRs
   
   Related issues: #4819
   Related pr:#4820
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org

[GitHub] [linkis] peacewong merged pull request #4820: issue-4819: fix illegal ec status and print error log

Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong merged PR #4820:
URL: https://github.com/apache/linkis/pull/4820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org

[GitHub] [linkis] peacewong commented on a diff in pull request #4820: issue-4819: fix illegal ec status and print error log

Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong commented on code in PR #4820:
URL: https://github.com/apache/linkis/pull/4820#discussion_r1273536865


##########
linkis-engineconn-plugins/spark/src/main/scala/org/apache/linkis/engineplugin/spark/mdq/MDQPostExecutionHook.scala:
##########
@@ -56,7 +56,12 @@ class MDQPostExecutionHook extends SparkPostExecutionHook with Logging {
       case l: CodeLanguageLabel => l.getCodeType
       case _ => ""
     }
-    if (StringUtils.isEmpty(runType) || !SparkKind.FUNCTION_MDQ_TYPE.equalsIgnoreCase(runType)) {
+    val linkisVar = "val linkisVar=1"

Review Comment:
   defined as a public variable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org