You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/03/05 22:30:13 UTC

[jira] [Commented] (BOOKKEEPER-581) Ledger recovery doesn't work correctly when recovery adds force changing ensembles.

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593935#comment-13593935 ] 

Hadoop QA commented on BOOKKEEPER-581:
--------------------------------------

Testing JIRA BOOKKEEPER-581


Patch [BOOKKEEPER-581.patch|https://issues.apache.org/jira/secure/attachment/12572162/BOOKKEEPER-581.patch] downloaded at Tue Mar  5 20:59:16 UTC 2013

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
.    Tests run: 819
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/283/
                
> Ledger recovery doesn't work correctly when recovery adds force changing ensembles.
> -----------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-581
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-581
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>    Affects Versions: 4.2.0, 4.2.1
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>            Priority: Critical
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-581.patch
>
>
> currently read and write use same ledger metadata during ledger recovery, which is bad. since write will cause changing ensemble which modified ensembles map to introducing brand new bookies. those brand new bookies would mislead following recovery reads, cause recovery is proceeded in a wrong way.
> E.g.
> 3 bookies, quorums size 2. A, B, C.
> read 0 from A, B.
> recovery add 0: A, B becomes slow. D, E are brought into the ensemble to replace A, B.
> so following recovery read would be proceed in ensemble (D, E, C), then we would lost all the entries added in A and B.
> this issue is similar as BOOKKEEPER-355.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira