You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/10 20:33:35 UTC

[GitHub] feng-tao commented on a change in pull request #4412: [AIRFLOW-3605] Load plugins from entry_points

feng-tao commented on a change in pull request #4412: [AIRFLOW-3605] Load plugins from entry_points
URL: https://github.com/apache/airflow/pull/4412#discussion_r246911327
 
 

 ##########
 File path: tests/plugins/test_plugins_manager_www.py
 ##########
 @@ -83,3 +85,66 @@ def test_menu_links(self):
         [menu_link] = [ml for ml in category.get_children()
                        if isinstance(ml, MenuLink)]
         self.assertEqual('Test Menu Link', menu_link.name)
+
+
+class MockPluginA(AirflowPlugin):
 
 Review comment:
   sorry, but could you move the MockPlugin to test_plugin file which is a centralized place for all the test plugins?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services