You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by Weixin-Xu <gi...@git.apache.org> on 2017/12/29 06:50:21 UTC

[GitHub] trafodion pull request #1311: [TRAFODION-2818] For Server 2008, function pow...

Github user Weixin-Xu commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1311#discussion_r159030283
  
    --- Diff: win-odbc64/odbcclient/drvr35/sqltocconv.cpp ---
    @@ -36,6 +36,34 @@
     
     #define MAXCHARLEN 32768 //32K
     
    +// for server2008 when using function pow() then throws STATUS_ILLEGAL_INSTRUCTION
    +__int64 pow(int base, short scale)
    +{
    +	DWORD dwVersion = 0;
    +	DWORD dwBuild = 0;
    +
    +	dwVersion = GetVersion();
    +
    +	// Get the build number.
    +
    +	if (dwVersion < 0x80000000)
    +		dwBuild = (DWORD)(HIWORD(dwVersion));
    +
    +	__int64 retValue = 1;
    +	if (dwBuild == 7600)
    +	{
    +		scale = scale > 18 ? 18 : scale;
    +		for (int i = 0; i < scale; i++)
    +			retValue = retValue * 10;
    +	}
    +	else
    +	{
    +		retValue = pow((double)base, scale);
    --- End diff --
    
    I have token the advice, can you review it if you are free.


---