You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/05/30 17:16:54 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2514: MissingTopState when the leader comes back on the same host
desaikomal opened a new pull request, #2514:
URL: https://github.com/apache/helix/pull/2514
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
We currently don't handle the case where if the user has only one replica and the leader partition comes back on the same host as there are no other replica.
(Write a concise description including what, why, how)
### Tests
- [x] The following tests are written for this issue:
Testing done:
Added a test scenario in the JSON config file where the partition is brought oneline on the same host and validated that the test passes.
TestTopStateHandoffMetrics::failed configuration has one additional test scenario added.
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
mvn test is in progress (it got interrupted, so will send it once completes)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue merged pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "junkaixue (via GitHub)" <gi...@apache.org>.
junkaixue merged PR #2514:
URL: https://github.com/apache/helix/pull/2514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2514:
URL: https://github.com/apache/helix/pull/2514#issuecomment-1576995661
Thanks @parakhnr and @rahulrane50 for reviewing the change. This PR is ready to be merged, approved by @rahulrane50
Commit message: If you have a single replica and that goes offline and comes back on the same host, we don't reset the counter. This fixes the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on a diff in pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213697929
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance, currentTopStateInstance,
Review Comment:
+1 Why do need two branches here? Even if we simply remove this if condition as well as first check in reportSingleTopStateHandoff about same instance then also it will automatically take care of this case right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] parakhnr commented on a diff in pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "parakhnr (via GitHub)" <gi...@apache.org>.
parakhnr commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213691293
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance, currentTopStateInstance,
resourceName, partition, clusterStatusMonitor, lastPipelineFinishTimestamp);
Review Comment:
I feel like we should modify the if check to just use `if (lastTopStateInstance !=null)` and reuse the `reportSingleTopStateHandoff` function instead by getting rid of the if statement that returns on `topStateInstance == currentTopStateInstance` in `reportSingleTopStateHandoff` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213771151
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance, currentTopStateInstance,
Review Comment:
Resolving as i updated the conditions in the other method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] parakhnr commented on a diff in pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "parakhnr (via GitHub)" <gi...@apache.org>.
parakhnr commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213692749
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance, currentTopStateInstance,
Review Comment:
I feel like we should modify the if check to just use `if (lastTopStateInstance !=null)` and reuse the `reportSingleTopStateHandoff` function for both usecases instead by getting rid of the if statement that returns on `topStateInstance == currentTopStateInstance` in `reportSingleTopStateHandoff` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2514: MissingTopState when the leader comes back on the same host
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2514:
URL: https://github.com/apache/helix/pull/2514#discussion_r1213736645
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -218,6 +217,8 @@ private void reportTopStateExistence(ResourceControllerDataProvider cache, Curre
// we observed an entire top state handoff process
reportSingleTopStateHandoff(cache, lastTopStateInstance, currentTopStateInstance,
Review Comment:
i can do that optimization but i had concern with this code:
// Make sure last top state instance has not bounced during cluster data cache refresh
if (cache.getLiveInstances().containsKey(lastTopStateInstance)) {
String lastTopStateSession =
cache.getLiveInstances().get(lastTopStateInstance).getEphemeralOwner();
// We need this null check as there are test cases creating incomplete current state
if (cache.getCurrentState(lastTopStateInstance, lastTopStateSession).get(resourceName)
!= null) {
startTime =
cache.getCurrentState(lastTopStateInstance, lastTopStateSession).get(resourceName)
.getStartTime(partition.getPartitionName());
fromTopStateUserLatency =
cache.getCurrentState(lastTopStateInstance, lastTopStateSession).get(resourceName)
.getEndTime(partition.getPartitionName()) - startTime;
}
}
So i wanted to first make sure change works properly and then optimize it but code de-dup. i can combine the two into one change.
let me know what you would prefer. i prefer the current approach but i am ready to hear reviewers choice too.
thanks,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org