[GitHub] [cassandra] clohfink commented on a change in pull request #340: CASSANDRA-15277 Make it possible to resize concurrent read / write thread pools at runtime

[GitBox <gi...@apache.org>]

clohfink commented on a change in pull request #340: CASSANDRA-15277 Make it possible to resize concurrent read / write thread pools at runtime
URL: https://github.com/apache/cassandra/pull/340#discussion_r313866103
 
 

 ##########
 File path: src/java/org/apache/cassandra/metrics/CassandraMetricsRegistry.java
 ##########
 @@ -186,6 +186,8 @@ else if (metric instanceof Timer)
             mbean = new JmxTimer((Timer) metric, name, TimeUnit.SECONDS, TimeUnit.MICROSECONDS);
         else if (metric instanceof Metered)
             mbean = new JmxMeter((Metered) metric, name, TimeUnit.SECONDS);
+        else if (metric instanceof IntegerSetting)
 
 Review comment:
   Codahale metrics are typically a read only thing, I think we can certainly go this route but then we have a 1 value in all of Cassandra set this way and I would prefer to see us move to Virtual Tables than to work to refactor all our JMX MBeans. The JMXEnabledThreadPoolExecutor also already has a `setMaximumThreads` so this will be confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org