You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/24 06:40:29 UTC

[GitHub] [spark] wangyum commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect

wangyum commented on a change in pull request #26230: [SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect
URL: https://github.com/apache/spark/pull/26230#discussion_r338403153
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
 ##########
 @@ -150,6 +151,30 @@ abstract class JdbcDialect extends Serializable {
   def beforeFetch(connection: Connection, properties: Map[String, String]): Unit = {
   }
 
+  /**
+   * Do some extra properties validation work in addition to the validation in [[JDBCOptions]],
+   * eg. [[validateFetchSize()]].
 
 Review comment:
   Please update the doc:
   ```scala
   [error] /home/jenkins/workspace/NewSparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/jdbc/JdbcDialect.java:121: error: reference not found
   [error]    * Do some extra properties validation work in addition to the validation in {@link JDBCOptions},
   [error]                                                                                       ^
   [error] /home/jenkins/workspace/NewSparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/jdbc/JdbcDialect.java:122: error: reference not found
   [error]    * eg. {@link validateFetchSize()}.
   [error] 
   ```
   
   https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4903/consoleFull

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org