You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:08:36 UTC

[GitHub] [spark] ueshin opened a new pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

ueshin opened a new pull request #33306:
URL: https://github.com/apache/spark/pull/33306


   ### What changes were proposed in this pull request?
   
   Properly set `InternalField` for `DataTypeOps.invert`.
   
   ### Why are the changes needed?
   
   The spark data type and nullability must be the same as the original when `DataTypeOps.invert`.
   We should manage `InternalField` for this case.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878601455


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45446/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878606395


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140934/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878587539


   **[Test build #140934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140934/testReport)** for PR 33306 at commit [`2af4a9a`](https://github.com/apache/spark/commit/2af4a9ad72c3e26e823b5aa81cc2208bf0080b43).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878571214


   **[Test build #140934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140934/testReport)** for PR 33306 at commit [`2af4a9a`](https://github.com/apache/spark/commit/2af4a9ad72c3e26e823b5aa81cc2208bf0080b43).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33306:
URL: https://github.com/apache/spark/pull/33306


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878621943


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45446/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878611244


   LGTM, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878606395


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140934/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878637666


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45446/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878571214


   **[Test build #140934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140934/testReport)** for PR 33306 at commit [`2af4a9a`](https://github.com/apache/spark/commit/2af4a9ad72c3e26e823b5aa81cc2208bf0080b43).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878637666


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45446/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878609171


   cc @HyukjinKwon @itholic @xinrong-databricks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33306: [SPARK-36103][PYTHON] Manage InternalField in DataTypeOps.invert

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33306:
URL: https://github.com/apache/spark/pull/33306#issuecomment-878683658


   Merged to master and branch-3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org