You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by pn...@apache.org on 2019/07/01 14:41:25 UTC

[flink] 16/16: [hotfix][network] Drop one testing constructor of CheckpointedInputGate

This is an automated email from the ASF dual-hosted git repository.

pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 6311a651bf66c393bca86af02fbabd9a9c4129e9
Author: Piotr Nowojski <pi...@gmail.com>
AuthorDate: Wed Jun 26 17:02:15 2019 +0200

    [hotfix][network] Drop one testing constructor of CheckpointedInputGate
---
 .../flink/streaming/runtime/io/CheckpointedInputGate.java  | 14 --------------
 .../io/CheckpointBarrierAlignerMassiveRandomTest.java      |  2 +-
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
index ce80e30..8e82a00 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointedInputGate.java
@@ -18,7 +18,6 @@
 package org.apache.flink.streaming.runtime.io;
 
 import org.apache.flink.annotation.Internal;
-import org.apache.flink.annotation.VisibleForTesting;
 import org.apache.flink.runtime.io.AsyncDataInput;
 import org.apache.flink.runtime.io.network.api.CancelCheckpointMarker;
 import org.apache.flink.runtime.io.network.api.CheckpointBarrier;
@@ -63,19 +62,6 @@ public class CheckpointedInputGate implements AsyncDataInput<BufferOrEvent> {
 	 * {@link #bufferStorage}. */
 	private boolean isFinished;
 
-	/**
-	 * Creates a new checkpoint stream aligner.
-	 *
-	 * <p>There is no limit to how much data may be buffered during an alignment.
-	 *
-	 * @param inputGate The input gate to draw the buffers and events from.
-	 * @param bufferStorage The storage to hold the buffers and events for blocked channels.
-	 */
-	@VisibleForTesting
-	CheckpointedInputGate(InputGate inputGate, BufferStorage bufferStorage) {
-		this (inputGate, bufferStorage, "Testing: No task associated", null);
-	}
-
 	public CheckpointedInputGate(
 			InputGate inputGate,
 			BufferStorage bufferStorage,
diff --git a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAlignerMassiveRandomTest.java b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAlignerMassiveRandomTest.java
index 7da0aa3..82920aa 100644
--- a/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAlignerMassiveRandomTest.java
+++ b/flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierAlignerMassiveRandomTest.java
@@ -62,7 +62,7 @@ public class CheckpointBarrierAlignerMassiveRandomTest {
 					new BufferPool[] { pool1, pool2 },
 					new BarrierGenerator[] { new CountBarrier(100000), new RandomBarrier(100000) });
 
-			CheckpointedInputGate checkpointedInputGate = new CheckpointedInputGate(myIG, new BufferSpiller(ioMan, myIG.getPageSize()));
+			CheckpointedInputGate checkpointedInputGate = new CheckpointedInputGate(myIG, new BufferSpiller(ioMan, myIG.getPageSize()), "Testing: No task associated", null);
 
 			for (int i = 0; i < 2000000; i++) {
 				BufferOrEvent boe = checkpointedInputGate.pollNext().get();