You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Anthony Baker (JIRA)" <ji...@apache.org> on 2017/06/17 18:04:15 UTC

[jira] [Closed] (GEODE-2523) Collapse RegionTestableTypes combinations into a single enum types

     [ https://issues.apache.org/jira/browse/GEODE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Baker closed GEODE-2523.
--------------------------------

> Collapse RegionTestableTypes combinations into a single enum types
> ------------------------------------------------------------------
>
>                 Key: GEODE-2523
>                 URL: https://issues.apache.org/jira/browse/GEODE-2523
>             Project: Geode
>          Issue Type: Sub-task
>          Components: lucene
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>             Fix For: 1.2.0
>
>
> Currently, we have pairs of RegionTestableTypes that are used in the LuceneDUnit tests.  These pairs are used to determine the datastore and accessor region types.  However the pairings are generally 1 to 1.  So we should be able to collapse the types into a single enum and remove the parameterized methods.  Instead we should then be able to add the enum name into the parameters themselves.
> So instead of having the following for a test case
>  @Parameters(method = "getListOfClientServerTypes")
> We could then have
>   @Parameters({"PARTITION", "ETC..."})
> we can probably use PARTITION and know that the corresponding client type is PARTITION_PROXY.  That or we can change the enum to be explicit about the pairing, such as PARTITION_WITH_PARTITION_PROXY.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)