You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/16 22:09:49 UTC
[GitHub] [incubator-nuttx-apps] michallenc opened a new pull request #595: canutils: changed print_usage function to static
michallenc opened a new pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595
## Summary
Global print_usage function in canutils/candump/ was causing double definition error while compiling NuttX with some extern apps, like pysimCoder for example. Therefore the following change to static function. To be on safe side, the same change was also done in cansend.
## Testing
Tested on Teensy 4.1 with pysimCoder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #595: canutils: changed print_usage function to static
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595#issuecomment-780458668
So, let's ignore the style issue and merge the correct fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] michallenc commented on pull request #595: canutils: changed print_usage function to static
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595#issuecomment-780154546
Oh, wasn´t expecting that much nx style errors. Gonna have to get some sleep before fixing this, I´ll push nx style changes tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #595: canutils: changed print_usage function to static
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] michallenc commented on pull request #595: canutils: changed print_usage function to static
Posted by GitBox <gi...@apache.org>.
michallenc commented on pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595#issuecomment-780385812
@btashton Well I definitely wouldn´t mind if we just merge it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] btashton commented on pull request #595: canutils: changed print_usage function to static
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #595:
URL: https://github.com/apache/incubator-nuttx-apps/pull/595#issuecomment-780156863
> Oh, wasn´t expecting that much nx style errors. Gonna have to get some sleep before fixing this, I´ll push nx style changes tomorrow.
I think for canutils we have in the past just left it as is to closely match the upstream and make it easier to backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org