You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/04 12:29:23 UTC
[GitHub] [kafka] akatona84 opened a new pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
akatona84 opened a new pull request #11174:
URL: https://github.com/apache/kafka/pull/11174
* URL wasn't urlencoded when forwarded reconfiguration to leader connect worker
* handling previously swallowed errors in connect RestClient
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
dadufour commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030
Any chance to have it in a 2.7.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-911379969
@akatona84 Thanks for the fix and sorry again for the delay merging it.
@dadufour At this point, it's unlikely there will be a 2.7.2 release. I've backported it to 2.8 so it will be in the 2.8.1 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] scholzj commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
scholzj commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-911647841
Great, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-902006686
> Thanks for the PR, it looks good. Is it possible to add a test for it?
@mimaison , Thanks for the review, unfortunately that code part where the restclient is used, not unit tested at all. It would need more effort to fully understand how the distributed herder could be tested better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-892623567
@kkonstantine , @rhauch could you take a look on this minor fix with big impact? Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
dadufour commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-911390634
Thanks for the feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-933641417
Applied to 3.0: https://github.com/apache/kafka/commit/9218b8cc5f10a1fb79c74e9a49ab36fd51e68916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-911644486
@scholzj Yes that's the plan, I'll do it when merging into 3.0 reopens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-893504255
Thanks for the PR, it looks good. Is it possible to add a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] scholzj commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
scholzj commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-911607580
@mimaison Will this also get into the 3.0.x release stream? I know it is probably late for 3.0.0 which already has RCs, so that is fine. But it would be nice to have it in 3.0.1 (if there ever is a 3.0.1 of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
dadufour commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030
Any chance to have it in a 2.7.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-892618088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #11174:
URL: https://github.com/apache/kafka/pull/11174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
dadufour commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030
Any chance to have it in a 2.7.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-892618088
Thanks @urbandan for investigating this issue with me and creating the fix. Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely
Posted by GitBox <gi...@apache.org>.
akatona84 commented on pull request #11174:
URL: https://github.com/apache/kafka/pull/11174#issuecomment-892638494
I'm not sure who puts these lines in the final commit message, but pls make sure that put Daniel in it too:
```
Co-authored-by: Daniel Urban <du...@cloudera.com>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org