[jira] [Updated] (SOLR-5649) Small ConnectionManager improvements

["Mark Miller (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-5649:
------------------------------

             Priority: Minor  (was: Trivial)
    Affects Version/s:     (was: 4.7)
                       4.6.1
        Fix Version/s: 5.0
             Assignee: Mark Miller
           Issue Type: Bug  (was: Improvement)

> Small ConnectionManager improvements
> ------------------------------------
>
>                 Key: SOLR-5649
>                 URL: https://issues.apache.org/jira/browse/SOLR-5649
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.6.1
>            Reporter: Gregory Chanan
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, 4.7
>
>
> I was just looking through the ConnectionManager and want to jot these down before I forget them.  I'm happy to make a patch if someone thinks it's valuable as well.
> - "clientConnected" doesn't seem to be read, can be eliminated
> - "state" is a private volatile variable, but only used in one function -- seems unlikely private volatile is what is wanted
> - A comment explaining why disconnected() is not called in the case of Expired would be helpful (Expired means we have already waited the timeout period so we want to reject updates right away)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org