You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org> on 2025/09/30 00:21:40 UTC
[PR] refactor(arrow): last increment of the Record -> RecordBatch migration [arrow-go]
Mandukhai-Alimaa opened a new pull request, #522:
URL: https://github.com/apache/arrow-go/pull/522
### Rationale for this change
Rename the Record interface to RecordBatch for clarity, since Record commonly means a single row but this type represents a batch of rows.
### What changes are included in this PR?
The rest of the code is now changed to use the RecordBatch method and updated interface.
### Are these changes tested?
Yes. All affected packages build successfully and core tests pass.
### Are there any user-facing changes?
No user facing API changes.
Closes #457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(arrow): last increment of the Record -> RecordBatch migration [arrow-go]
Posted by "Mandukhai-Alimaa (via GitHub)" <gi...@apache.org>.
Mandukhai-Alimaa commented on code in PR #522:
URL: https://github.com/apache/arrow-go/pull/522#discussion_r2408248097
##########
.golangci.yaml:
##########
@@ -31,10 +31,6 @@ linters:
- third_party$
- builtin$
- examples$
- rules:
- - linters:
- - staticcheck
- text: "SA1019"
Review Comment:
I originally added this rule at the start of the migration to suppress deprecated warnings during pre-commit checks. Now that the code has been updated to use RecordBatch instead of the deprecated Record, the linter should pass without needing to ignore those warnings, so this rule is no longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(arrow): last increment of the Record -> RecordBatch migration [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #522:
URL: https://github.com/apache/arrow-go/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(arrow): last increment of the Record -> RecordBatch migration [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #522:
URL: https://github.com/apache/arrow-go/pull/522#discussion_r2407044792
##########
.golangci.yaml:
##########
@@ -31,10 +31,6 @@ linters:
- third_party$
- builtin$
- examples$
- rules:
- - linters:
- - staticcheck
- text: "SA1019"
Review Comment:
Why removing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(arrow): last increment of the Record -> RecordBatch migration [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #522:
URL: https://github.com/apache/arrow-go/pull/522#discussion_r2408267971
##########
.golangci.yaml:
##########
@@ -31,10 +31,6 @@ linters:
- third_party$
- builtin$
- examples$
- rules:
- - linters:
- - staticcheck
- text: "SA1019"
Review Comment:
Ah! Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org