You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/15 00:42:01 UTC
[PR] fix(ci): remove Python 3.10 from the test matrix to unblock CI [superset]
rusackas opened a new pull request, #42058:
URL: https://github.com/apache/superset/pull/42058
### SUMMARY
Alternate, narrower fix for the master CI breakage described in #42007: drops Python 3.10 from the `previous` tier of the GHA test matrix instead of pinning `syntaqlite` back down.
**Root cause (from #42007):** `syntaqlite` 0.5.0+ (bumped to 0.6.0 in #41952) unconditionally imports `enum.StrEnum`, which doesn't exist before Python 3.11. `superset/sql_validators/sqlite.py` imports `syntaqlite` on the app-init path, so any test that builds the app fails at import time on the Python 3.10 ("previous") leg. That leg only runs on pushes to master (not PRs), which is why #41952 merged green and the break only surfaced on the next master push touching Python files.
**Why this approach instead of #42007's `syntaqlite` pin-revert:** Python 3.10 is close to upstream EOL (October 2026) and a fuller removal of 3.10 support is already in flight (#42045 — packaging metadata, docs, code-shim cleanup). Rather than reintroducing an older `syntaqlite` pin that will just get re-bumped and need re-pinning again, this stops testing 3.10 in CI now so master goes green immediately, without blocking on or duplicating the broader removal PR.
**Scope, deliberately narrow:** only touches `.github/actions/setup-backend/action.yml` (drops the `previous` → `3.10` alias) and the four workflows that consume it (`pre-commit.yml`, `superset-extensions-cli.yml`, `superset-python-integrationtest.yml`, `superset-python-unittest.yml`). It intentionally leaves `pyproject.toml`'s `requires-python`, docs, Docker image presets, and the `sys.version_info` compat shims in `superset/app.py` / `superset/middleware/legacy_prefix_redirect.py` / `superset/utils/backports.py` untouched — those are covered by #42045 if/when it lands. If #42045 merges first, this PR becomes redundant and can be closed instead.
### TESTING INSTRUCTIONS
- `pre-commit run --files <changed files>` passes (yaml validity, zizmor GHA security audit, etc.)
- Diffed against `origin/master` to confirm the change is exactly the five matrix/alias lines below, no incidental changes:
- `setup-backend/action.yml`: removed the `elif [ "$INPUT_PYTHON_VERSION" = "previous" ]; then RESOLVED_VERSION="3.10"` branch
- Four workflow files: `["previous", "current", "next"]` / `["current", "previous", "next"]` → `["current", "next"]` in the push/master matrix expression
### ADDITIONAL INFORMATION
- [ ] Has associated issue: alternate to #42007; overlaps with #42045 (which supersedes this once merged)
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [x] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): remove Python 3.10 from the test matrix to unblock CI [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42058:
URL: https://github.com/apache/superset/pull/42058#issuecomment-4975559949
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): remove Python 3.10 from the test matrix to unblock CI [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42058:
URL: https://github.com/apache/superset/pull/42058#issuecomment-4975669990
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42058?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.26%. Comparing base ([`be768ef`](https://app.codecov.io/gh/apache/superset/commit/be768efc0f4ccac73f21688b477b6479981f1de0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d79d686`](https://app.codecov.io/gh/apache/superset/commit/d79d686608908ae84abb3f391450b7ab5a558b60?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42058 +/- ##
==========================================
- Coverage 64.49% 64.26% -0.23%
==========================================
Files 2747 2747
Lines 153843 153843
Branches 35268 35268
==========================================
- Hits 99215 98867 -348
- Misses 52718 53076 +358
+ Partials 1910 1900 -10
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.06% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.04% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.70% <ø> (-0.46%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/42058/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.55% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42058?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ci): remove Python 3.10 from the test matrix to unblock CI [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42058:
URL: https://github.com/apache/superset/pull/42058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org