You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/12/16 17:55:20 UTC
Review Request 41450: SQOOP-2745 Using datetime column as a splitter
for Oracle no longer works
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41450/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2745
https://issues.apache.org/jira/browse/SQOOP-2745
Repository: sqoop-trunk
Description
-------
I've fixed the method by changing the header to getSplitters(int, long) and it seems to be working now.
Diffs
-----
src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 15c5898
src/test/com/cloudera/sqoop/ThirdPartyTests.java 06b4ae6
src/test/org/apache/sqoop/manager/oracle/OracleSplitterTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/41450/diff/
Testing
-------
I've also added a new test case covering the problem.
Thanks,
Jarek Cecho
Re: Review Request 41450: SQOOP-2745 Using datetime column as a
splitter for Oracle no longer works
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41450/#review110892
-----------------------------------------------------------
Ship it!
Ship It!
- Venkat Ranganathan
On Dec. 16, 2015, 8:55 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41450/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 8:55 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2745
> https://issues.apache.org/jira/browse/SQOOP-2745
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> I've fixed the method by changing the header to getSplitters(int, long) and it seems to be working now.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/db/OracleDataDrivenDBInputFormat.java 15c5898
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 06b4ae6
> src/test/org/apache/sqoop/manager/oracle/OracleSplitterTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/41450/diff/
>
>
> Testing
> -------
>
> I've also added a new test case covering the problem.
>
>
> Thanks,
>
> Jarek Cecho
>
>