[GitHub] Fokko closed pull request #4283: [AIRFLOW-3450] Remove unnecessary sigint handler

[GitBox <gi...@apache.org>]

Fokko closed pull request #4283: [AIRFLOW-3450] Remove unnecessary sigint handler
URL: https://github.com/apache/incubator-airflow/pull/4283
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py
index de6f0c9cab..bcb65c1052 100644
--- a/airflow/bin/cli.py
+++ b/airflow/bin/cli.py
@@ -85,10 +85,6 @@
     DAGS_FOLDER = '[AIRFLOW_HOME]/dags'
 
 
-def sigint_handler(sig, frame):
-    sys.exit(0)
-
-
 def sigquit_handler(sig, frame):
     """Helps debug deadlocks by printing stacktraces when this gets a SIGQUIT
     e.g. kill -s QUIT <PID> or CTRL+\
@@ -997,8 +993,6 @@ def scheduler(args):
         stdout.close()
         stderr.close()
     else:
-        signal.signal(signal.SIGINT, sigint_handler)
-        signal.signal(signal.SIGTERM, sigint_handler)
         signal.signal(signal.SIGQUIT, sigquit_handler)
         job.run()
 
@@ -1076,9 +1070,6 @@ def worker(args):
         stdout.close()
         stderr.close()
     else:
-        signal.signal(signal.SIGINT, sigint_handler)
-        signal.signal(signal.SIGTERM, sigint_handler)
-
         sp = subprocess.Popen(['airflow', 'serve_logs'], env=env, close_fds=True)
 
         worker.run(**options)
@@ -1306,9 +1297,6 @@ def flower(args):
         stdout.close()
         stderr.close()
     else:
-        signal.signal(signal.SIGINT, sigint_handler)
-        signal.signal(signal.SIGTERM, sigint_handler)
-
         os.execvp("flower", ['flower', '-b',
                              broka, address, port, api, flower_conf, url_prefix, basic_auth])
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services