[jira] [Commented] (SOLR-6613) TextField.analyzeMultiTerm should not throw exception when analyzer returns no term

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002645#comment-17002645 ] 

David Smiley commented on SOLR-6613:
------------------------------------

+1 to the proposal

> TextField.analyzeMultiTerm should not throw exception when analyzer returns no term
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-6613
>                 URL: https://issues.apache.org/jira/browse/SOLR-6613
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 4.3.1, 4.10.2, 6.0
>            Reporter: Bruno Roustant
>            Priority: Major
>         Attachments: TestTextField.java
>
>
> In TextField.analyzeMultiTerm()
> at line
> try {
>   if (!source.incrementToken())
>     throw new SolrException();
> The method should not throw an exception if there is no token because having no token is legitimate because all tokens may be filtered out (e.g. with a blocking Filter such as StopFilter).
> In this case it should simply return null (as it already returns null in some cases, see first line of method). However, SolrQueryParserBase needs also to be fixed to correctly handle null returned by TextField.analyzeMultiTerm().
> See attached TestTextField for the corresponding new test class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org