[GitHub] [druid] vogievetsky commented on a diff in pull request #13050: Web console: fix number of expected functions

[GitBox <gi...@apache.org>]

vogievetsky commented on code in PR #13050:
URL: https://github.com/apache/druid/pull/13050#discussion_r966196522


##########
web-console/script/create-sql-docs.js:
##########
@@ -90,15 +90,15 @@ const readDoc = async () => {
 
   // Make sure there are enough functions found
   const numFunction = Object.keys(functionDocs).length;
-  if (numFunction < MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS) {
+  if (!(MINIMUM_EXPECTED_NUMBER_OF_FUNCTIONS <= numFunction)) {

Review Comment:
   they behave differently if `numFunctions` is `undefined` because all comparisons with undefined are always false:
   
   <img width="145" alt="image" src="https://user-images.githubusercontent.com/177816/189180402-14b543bd-35f2-4cef-aca0-04864660ed29.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org