[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #7538: stm32_eth: Fix in assertion parameters.

[GitBox <gi...@apache.org>]

fjpanag opened a new pull request, #7538:
URL: https://github.com/apache/incubator-nuttx/pull/7538

   ## Summary
   
   Fixes an assertion in STM32 Ethernet driver.
   
   Since this code is about to use the STM32 buffers, I think it is more correct to check against this size, instead of the size of the Ethernet buffer size.
   
   Typically `CONFIG_NET_ETH_PKTSIZE` and `CONFIG_STM32_ETH_BUFSIZE` are equal (so the functionality of the code does not change), but I think this way it is "more correct". Especially in any special case that these two macros have different value.
   
   ## Impact
   
   N/A
   
   ## Testing
   
   Basic network test on an STM32F427.  
   I didn't notice this assertion to fail.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7538: stm32_eth: Fix in assertion parameters.

[GitBox <gi...@apache.org>]

xiaoxiang781216 merged PR #7538:
URL: https://github.com/apache/incubator-nuttx/pull/7538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org