You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "mobuchowski (via GitHub)" <gi...@apache.org> on 2024/09/01 10:18:03 UTC

Re: [PR] feat: notify about potential serialization failures when sending DagRun, don't serialize unnecessary params, guard listener for exceptions [airflow]

mobuchowski commented on code in PR #41690:
URL: https://github.com/apache/airflow/pull/41690#discussion_r1740044877


##########
airflow/providers/openlineage/utils/utils.py:
##########
@@ -439,11 +438,14 @@ def get_airflow_job_facet(dag_run: DagRun) -> dict[str, AirflowJobFacet]:
     }
 
 
-def get_airflow_state_run_facet(dag_run: DagRun) -> dict[str, AirflowStateRunFacet]:
+def get_airflow_state_run_facet(
+    dag_id: str, run_id: str, task_ids: list[str], state: DagRunState

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org