You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Stefan Oestreicher (JIRA)" <ji...@apache.org> on 2008/08/15 02:17:44 UTC
[jira] Created: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
improve NumberFormatTransformers handling of invalid input
----------------------------------------------------------
Key: SOLR-704
URL: https://issues.apache.org/jira/browse/SOLR-704
Project: Solr
Issue Type: Improvement
Components: contrib - DataImportHandler
Reporter: Stefan Oestreicher
Priority: Minor
As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
Posted by "Stefan Oestreicher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Oestreicher updated SOLR-704:
------------------------------------
Attachment: SOLR-704.patch
I updated the patch according to the latest changes in trunk. This is a diff against trunk 686186. I also added another test to demonstrate that "124,,789" or "123,45" parse without failure (with and without the fix).
> improve NumberFormatTransformers handling of invalid input
> ----------------------------------------------------------
>
> Key: SOLR-704
> URL: https://issues.apache.org/jira/browse/SOLR-704
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Reporter: Stefan Oestreicher
> Priority: Minor
> Attachments: SOLR-704.patch, SOLR-704.patch
>
>
> As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-704:
---------------------------------------
Fix Version/s: 1.3
Assignee: Shalin Shekhar Mangar
Affects Version/s: 1.3
> improve NumberFormatTransformers handling of invalid input
> ----------------------------------------------------------
>
> Key: SOLR-704
> URL: https://issues.apache.org/jira/browse/SOLR-704
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Stefan Oestreicher
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-704.patch, SOLR-704.patch
>
>
> As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-704:
---------------------------------------
Issue Type: Bug (was: Improvement)
Changing issue type to bug because the current behavior can silently ignore part of the string leading to invalid/incomplete data with no notification to the user.
> improve NumberFormatTransformers handling of invalid input
> ----------------------------------------------------------
>
> Key: SOLR-704
> URL: https://issues.apache.org/jira/browse/SOLR-704
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Stefan Oestreicher
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-704.patch, SOLR-704.patch
>
>
> As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
Posted by "Stefan Oestreicher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Oestreicher updated SOLR-704:
------------------------------------
Attachment: SOLR-704.patch
This is a diff against r686094
> improve NumberFormatTransformers handling of invalid input
> ----------------------------------------------------------
>
> Key: SOLR-704
> URL: https://issues.apache.org/jira/browse/SOLR-704
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Reporter: Stefan Oestreicher
> Priority: Minor
> Attachments: SOLR-704.patch
>
>
> As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-704) improve NumberFormatTransformers
handling of invalid input
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-704.
----------------------------------------
Resolution: Fixed
Committed revision 686196.
Thanks Stefan!
> improve NumberFormatTransformers handling of invalid input
> ----------------------------------------------------------
>
> Key: SOLR-704
> URL: https://issues.apache.org/jira/browse/SOLR-704
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 1.3
> Reporter: Stefan Oestreicher
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-704.patch, SOLR-704.patch
>
>
> As described in http://www.ibm.com/developerworks/java/library/j-numberformat/ instances of the NumberFormat class don't throw ParseExceptions in all cases of invalid input. This affects the org.apache.solr.handler.dataimport.NumberFormatTransformer class which relies on NumberFormat. I will attach a patch to demonstrate and fix this issue shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.