Re: [PR] fix(io): attempt every S3 delete and report how many failed [iceberg-cpp]

["kamcheungting-db (via GitHub)" <gi...@apache.org>]

kamcheungting-db commented on code in PR #966:
URL: https://github.com/apache/iceberg-cpp/pull/966#discussion_r4179796208


##########
src/iceberg/arrow/s3/arrow_s3_file_io.cc:
##########
@@ -181,9 +185,11 @@ std::string CanonicalizeS3Scheme(std::string_view location) {
 class ArrowS3FileIO final : public FileIO, public SupportsStorageCredentials {
  public:
   ArrowS3FileIO(std::shared_ptr<::arrow::fs::FileSystem> arrow_fs,
-                std::unordered_map<std::string, std::string> default_properties)
+                std::unordered_map<std::string, std::string> default_properties,
+                size_t delete_threads)
       : default_file_io_(std::make_shared<ArrowFileSystemFileIO>(std::move(arrow_fs))),
-        default_properties_(std::move(default_properties)) {}
+        default_properties_(std::move(default_properties)),
+        delete_threads_(delete_threads) {}

Review Comment:
   ```suggestion
           num_delete_threads_(delete_threads) {}
   ```



##########
src/iceberg/arrow/s3/arrow_s3_file_io.cc:
##########
@@ -237,6 +243,7 @@ class ArrowS3FileIO final : public FileIO, public SupportsStorageCredentials {
 
   std::shared_ptr<ArrowFileSystemFileIO> default_file_io_;
   std::unordered_map<std::string, std::string> default_properties_;
+  size_t delete_threads_;

Review Comment:
   ```suggestion
     size_t num_delete_threads_;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org