You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by jvwing <gi...@git.apache.org> on 2017/09/10 21:10:13 UTC

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

Github user jvwing commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2017#discussion_r137959726
  
    --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/AbstractGCPProcessor.java ---
    @@ -55,6 +55,25 @@
                 .addValidator(StandardValidators.INTEGER_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor PROXY_HOST = new PropertyDescriptor
    +            .Builder().name("proxy-host")
    +            .displayName("Proxy host")
    +            .description("IP or hostname of the proxy to be used")
    +            .required(false)
    +            .expressionLanguageSupported(false)
    +            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
    +            .build();
    +
    +    public static final PropertyDescriptor PROXY_PORT = new PropertyDescriptor
    +            .Builder().name("proxy-port")
    +            .displayName("Proxy port")
    +            .description("Porxy port number")
    --- End diff --
    
    "**Porxy** port number" -  looks like a typo


---