You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/20 03:00:19 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1455: Add Timezone to Scalar::Time* types, and better timezone awareness to Datafusion's time types

liukun4515 commented on a change in pull request #1455:
URL: https://github.com/apache/arrow-datafusion/pull/1455#discussion_r772053132



##########
File path: datafusion/tests/sql.rs
##########
@@ -6615,3 +6622,357 @@ async fn csv_query_with_decimal_by_sql() -> Result<()> {
     assert_batches_eq!(expected, &actual);
     Ok(())
 }
+
+#[tokio::test]

Review comment:
       how about add some cases with different TIME_ZONE, for example `UTC-7` or `UTC+8`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org