[jira] [Commented] (YARN-8363) Upgrade common-langs version to 3.7 in hadoop-yarn-project

["Takanobu Asanuma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507900#comment-16507900 ] 

Takanobu Asanuma commented on YARN-8363:
----------------------------------------

Uploaded the 1st patch. I've confirmed that the native package build succeeds with the patch.

In most cases, I just renamed classes and methods. I'd like to explain the other modifications.
 * 0-argument constructor in NotImplementedException is removed. The patch specify a message to keep the compatibility.
 [https://github.com/apache/commons-lang/blob/LANG_2_6/src/main/java/org/apache/commons/lang/NotImplementedException.java#L82]

 * {{StringUtils.isAlpha}} breaks compatibility when the argument is an empty string. The regression test is {{TestResourceUtils.testGetResourceInformation.}}
{code:java}
org.apache.commons.lang.StringUtils.isAlpha("") // true
org.apache.commons.lang3.StringUtils.isAlpha("") // false
{code}

 * Since {{Range}} classes become a generic class, an additional logic is needed in {{BasePBImplRecordsTest}}. The regression test is {{TestPBImplRecords.testGetApplicationsRequestPBImpl}}.

> Upgrade common-langs version to 3.7 in hadoop-yarn-project
> ----------------------------------------------------------
>
>                 Key: YARN-8363
>                 URL: https://issues.apache.org/jira/browse/YARN-8363
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: YARN-8363.1.patch
>
>
> commons-lang 2.6 is widely used. Let's upgrade to 3.6.
> This jira is separated from HADOOP-10783.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org