You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/30 20:06:13 UTC
[kudu-CR] KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5280
to review the following change.
Change subject: KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
......................................................................
KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
This page was previously accessing peer->consensus() which could be NULL
in a tombstoned tablet.
Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/tserver-path-handlers.cc
2 files changed, 50 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/5280/1
--
To view, visit http://gerrit.cloudera.org:8080/5280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
......................................................................
KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
This page was previously accessing peer->consensus() which could be NULL
in a tombstoned tablet.
Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
Reviewed-on: http://gerrit.cloudera.org:8080/5280
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/tserver/tserver-path-handlers.cc
2 files changed, 50 insertions(+), 4 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1545. Fix crash when visiting tablet page for tombstoned tablet
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d53d2080c476fe02e2c4ab5482fe80387199377
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No