Inconsistencies makebase.sh

[Michael Osipov <mi...@apache.org>]

Friends,

I still see some inconsistencies and portability issues:

1. Some expressions, some are not. It should be consistently quoted to 
avoid whitespace issues or similar.
2. "cp -a" is not portable. Some platforms don't have it, e.g., HP-UX 
which I use for approx 10 years with Tomcat.
3. Evaluation uses sometimes backticks sometimes $(). Seems inconsistent.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Inconsistencies makebase.sh

["William L. Thomson Jr." <wl...@o-sinc.com>]

On Tue, 3 Jul 2018 20:09:44 +0200
Michael Osipov <mi...@apache.org> wrote:

> Friends,
> 
> I still see some inconsistencies and portability issues:
> 
> 1. Some expressions, some are not. It should be consistently quoted
> to avoid whitespace issues or similar.
> 2. "cp -a" is not portable. Some platforms don't have it, e.g., HP-UX 
> which I use for approx 10 years with Tomcat.
> 3. Evaluation uses sometimes backticks sometimes $(). Seems
> inconsistent.

Make sure to shellcheck the script, or any scripts
https://www.shellcheck.net/
https://github.com/koalaman/shellcheck

-- 
William L. Thomson Jr.