You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/12/23 09:19:37 UTC

[GitHub] [bookkeeper] StevenLuMT opened a new pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

StevenLuMT opened a new pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957


   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   bugfix:
   when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum
   when all bookies is in a rack,when the old bookie node is offline for machine is broken,the ReplicationWorker want call method BookKeeperAdmin.getReplacementBookiesByIndexes, but find minNumRacksPerWriteQuorum(default value is 2) is large than racksInQuorum,but enforceMinNumRacksPerWriteQuorum(default value is false) is not open for checking this rack.
   
   So I think we should charge enforceMinNumRacksPerWriteQuorum is closed,no need to check rack's information
    
   <img width="668" alt="image" src="https://user-images.githubusercontent.com/42990025/147206534-bf9f3568-4463-4727-89c4-85ef0f3e9924.png">
   <img width="808" alt="image" src="https://user-images.githubusercontent.com/42990025/147207554-8290677f-23e1-4077-84f3-ba7b352a8a30.png">
   
   
   ### Changes
   
   bugfix: when enforceMinNumRacksPerWriteQuorum is false, no need to check racks in quorum


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1000228177


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001285846


   @nicoloboschi @dlg99 @eolivelli
   if this pr has no problem , help me merge it ,thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT edited a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT edited a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1012020972


   @eolivelli @pkumar-singh 
   If you have time, please help me review it, thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001104223


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001104239


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001286043


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001285846


   @nicoloboschi @dlg99 @eolivelli
   if this pr has no problem , help me merge it ,thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001626584


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1012660756


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1000228177


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001287332


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] zymap commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1014063048


   https://github.com/apache/bookkeeper/pull/1941/files#r258714042 Here has a discussion about this issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001104239


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001104223


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1012020972


   @eolivelli @pkumar-singh 
   If you have time, please help me review it, thank you
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001626584


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1012660756


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001287332


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1014074218


   > https://github.com/apache/bookkeeper/pull/1941/files#r258714042 Here has a discussion about this issue.
   
   
   case :
   
   1) minNumRacksPerWriteQuorum(default value is 2)
   2) enforceMinNumRacksPerWriteQuorum(default value is false)
   3) no rack config(just use default-rack)
   isEnsembleAdheringToPlacementPolicy will return false, then it will be unexpected
   @jvrao @reddycharan @zymap 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1001286043


   @nicoloboschi @dlg99 @eolivelli
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1013786377


   @eolivelli @pkumar-singh @zymap 
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT commented on pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957#issuecomment-1012020972


   @nicoloboschi @pkumar-singh 
   If you have time, please help me review it, thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] StevenLuMT closed pull request #2957: bugfix for RackawareEnsemblePlacementPolicyImpl.isEnsembleAdheringToPlacementPolicy

Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #2957:
URL: https://github.com/apache/bookkeeper/pull/2957


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org