You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by xu...@apache.org on 2015/01/07 19:51:36 UTC

svn commit: r1650137 - in /hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client: JobHandle.java JobHandleImpl.java RemoteDriver.java

Author: xuefu
Date: Wed Jan  7 18:51:36 2015
New Revision: 1650137

URL: http://svn.apache.org/r1650137
Log:
HIVE-9288: TODO cleanup task1.[Spark Branch] (Chengxiang via Xuefu)

Modified:
    hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java
    hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java
    hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java

Modified: hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java
URL: http://svn.apache.org/viewvc/hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java?rev=1650137&r1=1650136&r2=1650137&view=diff
==============================================================================
--- hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java (original)
+++ hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandle.java Wed Jan  7 18:51:36 2015
@@ -54,6 +54,4 @@ public interface JobHandle<T extends Ser
    */
   SparkCounters getSparkCounters();
 
-  // TODO: expose job status?
-
 }

Modified: hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java
URL: http://svn.apache.org/viewvc/hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java?rev=1650137&r1=1650136&r2=1650137&view=diff
==============================================================================
--- hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java (original)
+++ hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/JobHandleImpl.java Wed Jan  7 18:51:36 2015
@@ -118,8 +118,6 @@ class JobHandleImpl<T extends Serializab
     this.sparkCounters = sparkCounters;
   }
 
-  // TODO: expose job status?
-
   @SuppressWarnings("unchecked")
   void setSuccess(Object result) {
     promise.setSuccess((T) result);

Modified: hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java
URL: http://svn.apache.org/viewvc/hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java?rev=1650137&r1=1650136&r2=1650137&view=diff
==============================================================================
--- hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java (original)
+++ hive/branches/spark/spark-client/src/main/java/org/apache/hive/spark/client/RemoteDriver.java Wed Jan  7 18:51:36 2015
@@ -371,7 +371,6 @@ public class RemoteDriver {
 
     @Override
     public void onJobStart(SparkListenerJobStart jobStart) {
-      // TODO: are stage IDs unique? Otherwise this won't work.
       synchronized (stageToJobId) {
         for (int i = 0; i < jobStart.stageIds().length(); i++) {
           stageToJobId.put((Integer) jobStart.stageIds().apply(i), jobStart.jobId());