You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4php-dev@logging.apache.org by Knut Urdalen <kn...@telio.no> on 2005/12/01 00:23:06 UTC

LoggerAppenderConsole - doesn't work with STDERR

I just found that the console appender doesn't work with STDERR because
of a minor typo. It seems like the STDERR constant check is fixed
between release 0.9 and subversion HEAD.
*
Patch against svn HEAD*

Index: appenders/LoggerAppenderConsole.php
===================================================================
--- appenders/LoggerAppenderConsole.php (revision 350067)
+++ appenders/LoggerAppenderConsole.php (working copy)
@@ -78,7 +78,7 @@
         if ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT or
strtoupper($v) == 'STDOUT') {
             $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT;
         } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR or
strtoupper($v) == 'STDERR') {
-            $target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;
+            $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;
         } else {
             LoggerLog::debug(
                 "LoggerAppenderConsole::targetWarn() ".
*
Diff against log4php release 0.9*

87,88c87,88
<         } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT or
strtoupper($v) == 'STDERR') {
<             $target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT;
---
>         } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR or
strtoupper($v) == 'STDERR') {
>             $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;

Regards,
Knut Urdalen
Software Developer
Telio Telecom AS

Re: LoggerAppenderConsole - doesn't work with STDERR

Posted by "Marco V." <ma...@apache.org>.
Fixed.
Again, thank You.

-Marco

----- Original Message ----- 
From: "Knut Urdalen" <kn...@telio.no>
To: <lo...@logging.apache.org>
Sent: Thursday, December 01, 2005 12:23 AM
Subject: LoggerAppenderConsole - doesn't work with STDERR


> I just found that the console appender doesn't work with STDERR because
> of a minor typo. It seems like the STDERR constant check is fixed
> between release 0.9 and subversion HEAD.
> *
> Patch against svn HEAD*
> 
> Index: appenders/LoggerAppenderConsole.php
> ===================================================================
> --- appenders/LoggerAppenderConsole.php (revision 350067)
> +++ appenders/LoggerAppenderConsole.php (working copy)
> @@ -78,7 +78,7 @@
>          if ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT or
> strtoupper($v) == 'STDOUT') {
>              $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT;
>          } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR or
> strtoupper($v) == 'STDERR') {
> -            $target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;
> +            $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;
>          } else {
>              LoggerLog::debug(
>                  "LoggerAppenderConsole::targetWarn() ".
> *
> Diff against log4php release 0.9*
> 
> 87,88c87,88
> <         } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT or
> strtoupper($v) == 'STDERR') {
> <             $target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDOUT;
> ---
> >         } elseif ($v == LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR or
> strtoupper($v) == 'STDERR') {
> >             $this->target = LOG4PHP_LOGGER_APPENDER_CONSOLE_STDERR;
> 
> Regards,
> Knut Urdalen
> Software Developer
> Telio Telecom AS
>