You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Bethard (JIRA)" <ji...@apache.org> on 2009/04/22 01:07:47 UTC

[jira] Created: (LUCENE-1608) CustomScoreQuery should support arbitrary Queries

CustomScoreQuery should support arbitrary Queries
-------------------------------------------------

                 Key: LUCENE-1608
                 URL: https://issues.apache.org/jira/browse/LUCENE-1608
             Project: Lucene - Java
          Issue Type: New Feature
          Components: Query/Scoring
            Reporter: Steven Bethard
            Priority: Minor


CustomScoreQuery only allows the secondary queries to be of type ValueSourceQuery instead of allowing them to be any type of Query. As a result, what you can do with CustomScoreQuery is pretty limited.

It would be nice to extend CustomScoreQuery to allow arbitrary Query objects. Most of the code should stay about the same, though a little more care would need to be taken in CustomScorer.score() to use 0.0 when the sub-scorer does not produce a score for the current document.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1608) CustomScoreQuery should support arbitrary Queries

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701683#action_12701683 ] 

Doron Cohen commented on LUCENE-1608:
-------------------------------------

I thought I had written a class exactly for this purpose but I was wrong - my class was different in that it had an actual value source, just that it was sparse - values for quite many docs were missing. It is similar in a way, but different since here the input is a query.

But I did promise... so I wrote a quick wrapper for a query to create a value source.
That value source can be used to create a value source query.

Although the patch coming soon is tested and all, I am not considering to commit this patch, because it is not clean. 

I would like to reorganize this package to take better care of this request and other related issues (like LUCENE-850) and to make it worth for Solr to move to use this package. (last time I checked it wasn't). But this is a different issue...

> CustomScoreQuery should support arbitrary Queries
> -------------------------------------------------
>
>                 Key: LUCENE-1608
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1608
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Query/Scoring
>            Reporter: Steven Bethard
>            Assignee: Doron Cohen
>            Priority: Minor
>
> CustomScoreQuery only allows the secondary queries to be of type ValueSourceQuery instead of allowing them to be any type of Query. As a result, what you can do with CustomScoreQuery is pretty limited.
> It would be nice to extend CustomScoreQuery to allow arbitrary Query objects. Most of the code should stay about the same, though a little more care would need to be taken in CustomScorer.score() to use 0.0 when the sub-scorer does not produce a score for the current document.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Commented: (LUCENE-1608) CustomScoreQuery should support arbitrary Queries

Posted by "Steven Bethard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709068#action_12709068 ] 

Steven Bethard commented on LUCENE-1608:
----------------------------------------

Sorry it took so long for me to try this out, but yes, this does exactly what I need. I'd love to see the package reorganized so that this kind of thing would be easier. I'm far from a Lucene expert, but if there's anything I can do to help, let me know and I'll try to make some time for it.

> CustomScoreQuery should support arbitrary Queries
> -------------------------------------------------
>
>                 Key: LUCENE-1608
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1608
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Query/Scoring
>            Reporter: Steven Bethard
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-1608.patch
>
>
> CustomScoreQuery only allows the secondary queries to be of type ValueSourceQuery instead of allowing them to be any type of Query. As a result, what you can do with CustomScoreQuery is pretty limited.
> It would be nice to extend CustomScoreQuery to allow arbitrary Query objects. Most of the code should stay about the same, though a little more care would need to be taken in CustomScorer.score() to use 0.0 when the sub-scorer does not produce a score for the current document.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Updated: (LUCENE-1608) CustomScoreQuery should support arbitrary Queries

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-1608:
--------------------------------

    Attachment: LUCENE-1608.patch

Patch for passing arbitrary queries to custom-score-query.
Not intended for committing.
See TestQueryWrapperValueSource for usage of this wrapper.
- Doron

> CustomScoreQuery should support arbitrary Queries
> -------------------------------------------------
>
>                 Key: LUCENE-1608
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1608
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Query/Scoring
>            Reporter: Steven Bethard
>            Assignee: Doron Cohen
>            Priority: Minor
>         Attachments: LUCENE-1608.patch
>
>
> CustomScoreQuery only allows the secondary queries to be of type ValueSourceQuery instead of allowing them to be any type of Query. As a result, what you can do with CustomScoreQuery is pretty limited.
> It would be nice to extend CustomScoreQuery to allow arbitrary Query objects. Most of the code should stay about the same, though a little more care would need to be taken in CustomScorer.score() to use 0.0 when the sub-scorer does not produce a score for the current document.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


[jira] Assigned: (LUCENE-1608) CustomScoreQuery should support arbitrary Queries

Posted by "Doron Cohen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen reassigned LUCENE-1608:
-----------------------------------

    Assignee: Doron Cohen

> CustomScoreQuery should support arbitrary Queries
> -------------------------------------------------
>
>                 Key: LUCENE-1608
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1608
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Query/Scoring
>            Reporter: Steven Bethard
>            Assignee: Doron Cohen
>            Priority: Minor
>
> CustomScoreQuery only allows the secondary queries to be of type ValueSourceQuery instead of allowing them to be any type of Query. As a result, what you can do with CustomScoreQuery is pretty limited.
> It would be nice to extend CustomScoreQuery to allow arbitrary Query objects. Most of the code should stay about the same, though a little more care would need to be taken in CustomScorer.score() to use 0.0 when the sub-scorer does not produce a score for the current document.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org