[jira] [Commented] (FLINK-4078) Use ClosureCleaner for CoGroup where

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333789#comment-15333789 ] 

ASF GitHub Bot commented on FLINK-4078:
---------------------------------------

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/2116

    [FLINK-4078] [java, DataSet] Introduce missing calls to closure cleaner

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink 4024-closure_cleaner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2116
    
----
commit 90ccdccfaab8b3261716e2f0cbf8deb846f86f08
Author: Stefan Richter <st...@gmail.com>
Date:   2016-06-16T10:11:32Z

    [FLINK-4078] [java, DataSet] Introduce missing calls to closure cleaner

----


> Use ClosureCleaner for CoGroup where
> ------------------------------------
>
>                 Key: FLINK-4078
>                 URL: https://issues.apache.org/jira/browse/FLINK-4078
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.0.3
>            Reporter: Ufuk Celebi
>            Assignee: Stefan Richter
>             Fix For: 1.1.0
>
>
> When specifying a key selector in the where clause of a CoGroup, the closure cleaner is not used.
> {code}
> .coGroup(filteredIds)
>                 .where(new KeySelector<T, String>() {
>                     @Override
>                     public String getKey(T t) throws Exception {
>                         String s = (String) t.get(fieldName);
>                         return s != null ? s : UUID.randomUUID().toString();
>                     }
>                 })
> {code}
> The problem is that the KeySelector is an anonymous inner class and as such as a reference to the outer object. Normally, this would be rectified by the closure cleaner but the cleaner is not used in CoGroup.where().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)