[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#discussion_r860431656


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobScheduler.java:
##########
@@ -86,7 +86,11 @@ protected void runAfterCatalogReady() {
                 LOG.info("The statistics task queue is full, schedule the job(id={}) later", pendingJob.getId());
             } catch (DdlException e) {
                 pendingJobQueue.remove();
-                pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+                try {
+                    // TODO change to without exception
+                    pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+                } catch (DdlException ddlException) {
+                }

Review Comment:
   I will add a LOG(FATAL)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org