You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/11 23:02:21 UTC
[GitHub] [commons-imaging] kinow opened a new pull request #68:
[IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be
interpreted by parsers in the specification
kinow opened a new pull request #68: [IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be interpreted by parsers in the specification
URL: https://github.com/apache/commons-imaging/pull/68
Specifically 1084, 1085, 1086, 1086 from https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/.
Unit test attached, using image provided in the JIRA issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-imaging] coveralls edited a comment on issue #68:
[IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be
interpreted by parsers in the specification
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #68: [IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be interpreted by parsers in the specification
URL: https://github.com/apache/commons-imaging/pull/68#issuecomment-573362644
[](https://coveralls.io/builds/28048710)
Coverage increased (+0.03%) to 74.97% when pulling **68d39c7913ce16544a255e27fcaabebc08cdf5c9 on kinow:IMAGING-246** into **7c5ba7472786dafc78f039228113c23a52f4b3ce on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-imaging] coveralls commented on issue #68: [IMAGING-246]
Skip Photoshop IPTC blocks that are not recommended to be interpreted by
parsers in the specification
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #68: [IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be interpreted by parsers in the specification
URL: https://github.com/apache/commons-imaging/pull/68#issuecomment-573362644
[](https://coveralls.io/builds/28048708)
Coverage increased (+0.03%) to 74.97% when pulling **68d39c7913ce16544a255e27fcaabebc08cdf5c9 on kinow:IMAGING-246** into **7c5ba7472786dafc78f039228113c23a52f4b3ce on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-imaging] kinow commented on a change in pull request #68:
[IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be
interpreted by parsers in the specification
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #68: [IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be interpreted by parsers in the specification
URL: https://github.com/apache/commons-imaging/pull/68#discussion_r365546675
##########
File path: src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java
##########
@@ -598,12 +598,12 @@ public JpegPhotoshopMetadata getPhotoshopMetadata(final ByteSource byteSource,
final App13Segment segment = (App13Segment) s;
final PhotoshopApp13Data data = segment.parsePhotoshopSegment(params);
- if (data != null && photoshopApp13Data != null) {
- throw new ImageReadException(
- "Jpeg contains more than one Photoshop App13 segment.");
+ if (data != null) {
+ if (photoshopApp13Data != null) {
+ throw new ImageReadException("Jpeg contains more than one Photoshop App13 segment.");
+ }
+ photoshopApp13Data = data;
Review comment:
The logic removed had an issue, where if the first data was not null, then the second was null; the second value would be used. Resulting in missing photoshop APP13 data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-imaging] kinow merged pull request #68: [IMAGING-246] Skip
Photoshop IPTC blocks that are not recommended to be interpreted by parsers
in the specification
Posted by GitBox <gi...@apache.org>.
kinow merged pull request #68: [IMAGING-246] Skip Photoshop IPTC blocks that are not recommended to be interpreted by parsers in the specification
URL: https://github.com/apache/commons-imaging/pull/68
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services